linux-kernel - Re: [PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 15 Aug 2015 12:10:10 +0700
From:	Lars Melin <larsm17@...il.com>
To:	Chase Metzger <chasemetzger15@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Petr Mladek <pmladek@...e.cz>,
	Peter Chen <peter.chen@...escale.com>,
	Felipe Balbi <balbi@...com>,
	Matthew Garrett <mjg59@...eos.com>,
	Robert Schlabbach <Robert.Schlabbach@....net>,
	Zhuang Jin Can <jin.can.zhuang@...el.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: core: hub: Removed some warnings generated by
 checkpatch.pl

On 2015-08-15 11:41, Chase Metzger wrote:
> Removed some checkpatch.pl warnings saying there was an unwanted space between
> function names and their arguments.
>
> Signed-off-by: Chase Metzger <chasemetzger15@...il.com>
> ---
>   drivers/usb/core/hub.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 38cb6d3..b9cab51 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -4218,7 +4218,7 @@ static int hub_enable_device(struct usb_device *udev)
>    * but it is still necessary to lock the port.
>    */
>   static int
> -hub_port_init (struct usb_hub *hub, struct usb_device *udev, int port1,
> +hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
>   		int retry_counter)
>   {
>   	struct usb_device	*hdev = hub->hdev;
> @@ -4522,7 +4522,7 @@ fail:
>   }
>
>   static void
> -check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
> +check_highspeed(struct usb_hub *hub, struct usb_device *udev, int port1)
>   {
>   	struct usb_qualifier_descriptor	*qual;
>   	int				status;
> @@ -4530,11 +4530,11 @@ check_highspeed (struct usb_hub *hub, struct usb_device *udev, int port1)
>   	if (udev->quirks & USB_QUIRK_DEVICE_QUALIFIER)
>   		return;
>
> -	qual = kmalloc (sizeof *qual, GFP_KERNEL);
> +	qual = kmalloc(sizeof *qual, GFP_KERNEL);
>   	if (qual == NULL)
>   		return;
>
> -	status = usb_get_descriptor (udev, USB_DT_DEVICE_QUALIFIER, 0,
> +	status = usb_get_descriptor udev, USB_DT_DEVICE_QUALIFIER, 0,
>   			qual, sizeof *qual);

If you had test compiled you would have got an unbalanced parenthesis 
error here. So you didn't test your patch..


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/