linux-kernel - Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Aug 2015 00:29:23 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Eduardo Valentin <edubezval@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>
CC:	linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	Daniel Kurtz <djkurtz@...omium.org>, kernel@...gutronix.de,
	Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

On 08/21/2015 12:20 AM, Eduardo Valentin wrote:
> On Thu, Aug 20, 2015 at 10:06:01AM +0200, Sascha Hauer wrote:
>> This adds support for the Mediatek thermal controller found on MT8173
>> and likely other SoCs.
>> The controller is a bit special. It does not have its own ADC, instead
>> it controls the on-SoC AUXADC via AHB bus accesses. For this reason
>> we need the physical address of the AUXADC. Also it controls a mux
>> using AHB bus accesses, so we need the APMIXEDSYS physical address aswell.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
>> ---

[ ... ]

>> +	/*
>> +	 * These calibration values should finally be provided by the
>> +	 * firmware or fuses. For now use default values.
>> +	 */
>> +	mt->calib_slope = -123;
>> +	mt->calib_offset = 465124;
>
> Would it make sense to use the coefficients device tree property to
> describe the sensor slope and offset?

Trim the mail when possible please.


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/