linux-kernel - Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C calculation via DMA engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Aug 2015 11:10:34 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Rameshwar Prasad Sahu <rsahu@....com>
Cc:	dan.j.williams@...el.com, herbert@...dor.apana.org.au,
	davem@...emloft.net, linux-crypto@...r.kernel.org,
	dmaengine@...r.kernel.org, arnd@...db.de,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, jcm@...hat.com,
	patches@....com
Subject: Re: [PATCH v1 2/4] dmaengine: xgene-dma: Add support for CRC32C
 calculation via DMA engine

On Thu, Jul 30, 2015 at 05:41:06PM +0530, Rameshwar Prasad Sahu wrote:
> +	/* Invalidate unused source address field */
> +	for (; i < 4; i++)
> +		xgene_dma_invalidate_buffer(xgene_dma_lookup_ext8(desc2, i));
> +
> +	/* Check whether requested buffer processed */
> +	if (nbytes) {
> +		chan_err(chan, "Src count crossed maximum limit\n");
> +		return -EINVAL;
no cleanup ?

> +struct dma_async_tx_descriptor *xgene_dma_prep_flyby(
> +	struct xgene_dma_chan *chan, struct scatterlist *src_sg,
> +	size_t len, u32 seed, u8 *result, unsigned long flags, u8 opcode)
please fix style here

> +struct dma_async_tx_descriptor *xgene_dma_prep_crc32c(
> +	struct dma_chan *dchan, struct scatterlist *src_sg,
> +	size_t len, u32 seed, u8 *result, unsigned long flags)
here too

> @@ -1309,8 +1512,13 @@ static void xgene_dma_setup_ring(struct xgene_dma_ring *ring)
>  		  ring->pdma->csr_ring + XGENE_DMA_RING_ID);
> 
>  	/* Set DMA ring buffer */
> -	iowrite32(XGENE_DMA_RING_ID_BUF_SETUP(ring->num),
> -		  ring->pdma->csr_ring + XGENE_DMA_RING_ID_BUF);
> +	ring_id_buf = XGENE_DMA_RING_ID_BUF_SETUP(ring->num);
> +
> +	if (ring->is_bufpool)
> +		ring_id_buf |= XGENE_DMA_RING_IS_BUFPOOL;
> +
> +	iowrite32(ring_id_buf, ring->pdma->csr_ring +
> +		  XGENE_DMA_RING_ID_BUF);
pls fix style here

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/