linux-kernel - CONFIG_OF vs DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Aug 2015 05:35:58 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>
CC:	<dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: CONFIG_OF vs DMA_OF


Hi Vinod

${LINUX}/drivers/dma/of-dma.c will be compiled if .config has DMA_OF

	obj-$(CONFIG_DMA_OF) += of-dma.o

But, ${LINUX}/include/linux/of_dma.h is based on CONFIG_OF

	#ifdef CONFIG_OF
	extern int of_dma_controller_register(struct device_node *np,
	...
	#else
	static inline int of_dma_controller_register(struct device_node *np,
	...
	#endif

I have issue if .config has CONFIG_OF but not have DMA_OF.
Is this correct patch ?

---------------------------------
diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
index 98ba752..9440622 100644
--- a/include/linux/of_dma.h
+++ b/include/linux/of_dma.h
@@ -34,7 +34,7 @@ struct of_dma_filter_info {
        dma_filter_fn   filter_fn;
 };
 
-#ifdef CONFIG_OF
+#ifdef DMA_OF
 extern int of_dma_controller_register(struct device_node *np,
                struct dma_chan *(*of_dma_xlate)
                (struct of_phandle_args *, struct of_dma *),
---------------------------------


Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/