linux-kernel - Re: [PATCH 00/18] ARM: use const and __initconst for smp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 10:37:15 +0900
From:	Masahiro Yamada <yamada.masahiro@...ionext.com>
To:	Olof Johansson <olof@...om.net>
Cc:	Russell King - ARM Linux <linux@....linux.org.uk>,
	Andrew Lunn <andrew@...n.ch>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Heiko Stuebner <heiko@...ech.de>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Santosh Shilimkar <ssantosh@...nel.org>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	Pavel Machek <pavel@....cz>,
	Florian Fainelli <f.fainelli@...il.com>,
	Stephen Warren <swarren@...dia.com>,
	Emilio López <emilio@...pez.com.ar>,
	Michal Simek <michal.simek@...inx.com>,
	Wei Xu <xuwei5@...ilicon.com>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	Chen-Yu Tsai <wens@...e.org>,
	"arm@...nel.org" <arm@...nel.org>,
	Broadcom Kernel Feedback List 
	<bcm-kernel-feedback-list@...adcom.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	linux-arm-msm <linux-arm-msm@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	David Brown <davidb@...eaurora.org>,
	Tsahee Zidenberg <tsahee@...apurnalabs.com>,
	Jason Cooper <jason@...edaemon.net>,
	Arnd Bergmann <arnd@...db.de>, Ray Jui <rjui@...adcom.com>,
	Andy Gross <agross@...eaurora.org>,
	Hans de Goede <hdegoede@...hat.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Gregory Fong <gregory.0xf0@...il.com>,
	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	linux-soc@...r.kernel.org, Jun Nie <jun.nie@...aro.org>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Brian Norris <computersforpeace@...il.com>,
	Scott Branden <sbranden@...adcom.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kukjin Kim <kgene@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH 00/18] ARM: use const and __initconst for smp_operations

Hi Russell, Olof,

2015-08-25 6:44 GMT+09:00 Olof Johansson <olof@...om.net>:
> On Mon, Aug 24, 2015 at 2:21 PM, Russell King - ARM Linux
> <linux@....linux.org.uk> wrote:
>> On Mon, Aug 24, 2015 at 02:12:06PM -0700, Olof Johansson wrote:
>>> Easiest of all would probably be to get the sub-arch patches into one
>>> release, then switch the prototypes and function definitions in the
>>> next. If you switch prototypes first you'll get a bunch of warnings,
>>> right?
>>
>> Wrong way around. :)
>>
>> If you change the sub-arches to declare the smp operations as const,
>> and try and pass them into a function which doesn't take a const-pointer,
>> you'll get a warning.  The core bits need to go in first before the
>> sub-arch patches.
>
> Ah yes, my bad.
>
>> I think the series has limited value - it allows us to (a) check that a
>> small quantity of code doesn't write to these things, and (b) allows us
>> to move the SMP operations structure from __initdata to __initconstdata.
>> It's still going to end up in the init region which is read/write in any
>> case, and still gets thrown away.
>>
>> Given where we are, I don't think we need to rush this in during the
>> last week before the merge window opens, even though it's trivial.
>
> Agreed. So if you pick it up for 4.4, we'll get the rest for 4.5.
>

OK.

I will put 01 and 02 to Russell's patch tracker
(after waiting for a bit more comments just in case).

I will do the rest later.





-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/