linux-kernel - Re: [PATCH] SCSI: dtc: Fixed a brace issue on return 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Aug 2015 11:54:55 +1000 (AEST)
From:	Finn Thain <fthain@...egraphics.com.au>
To:	Rudhresh <rudhresh.jk@...il.com>
cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] SCSI: dtc: Fixed a brace issue on return 0


On Sun, 28 Jun 2015, Rudhresh wrote:

> From: rudhresh <rudhresh.jk@...il.com>
> 
> Return is not a function so parenthesis is not required
> 
> Signed-off-by: Rudhresh <rudhresh.jk@...il.com>

Can you put your full name here?

You must address your patches to all of the interested parties (see 
scripts/get_maintainer.pl).

Please read Documentation/SubmittingPatches and adhere to the instructions 
therein.

-- 

>
> ---
>  drivers/scsi/dtc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
> index 4c74c7b..c793ecf 100644
> --- a/drivers/scsi/dtc.c
> +++ b/drivers/scsi/dtc.c
> @@ -363,7 +363,7 @@ static inline int NCR5380_pread(struct Scsi_Host *instance, unsigned char *dst,
>  	NCR5380_read(RESET_PARITY_INTERRUPT_REG);
>  	if (i > hostdata->spin_max_r)
>  		hostdata->spin_max_r = i;
> -	return (0);
> +	return 0;
>  }
>  
>  /****************************************************************
> @@ -417,7 +417,7 @@ static inline int NCR5380_pwrite(struct Scsi_Host *instance, unsigned char *src,
>  	rtrc(0);
>  	if (i > hostdata->spin_max_w)
>  		hostdata->spin_max_w = i;
> -	return (0);
> +	return 0;
>  }
>  
>  MODULE_LICENSE("GPL");
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/