linux-kernel - Re: [PATCH] irqdomain: remove the confused log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 09:50:14 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Huang Shijie <shijie.huang@....com>
cc:	jiang.liu@...ux.intel.com, marc.zyngier@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqdomain: remove the confused log

On Wed, 26 Aug 2015, Huang Shijie wrote:
> On Tue, Aug 25, 2015 at 09:34:00PM +0200, Thomas Gleixner wrote:
> > On Tue, 25 Aug 2015, Huang Shijie wrote:
> > 
> > > When the dynamic debug is enabled for irq domain, the kernel will print out:
> > >   ------------------------------------------------------
> > >     irqdomain:__irq_domain_add: irq: Added domain (null)
> > >   ------------------------------------------------------
> > > 
> > > It does not print out the irq domain's name, since the @domain->name is NULL.
> > > Keep the log here just makes people nervous.
> > 
> > Well, it might be NULL in your case, but there are enough cases where
> > its not NULL and the output valuable. 
> In which case ?
> 
> The domain is allocated by kzalloc_node(), so @domain->name is NULL in the function.
> The @domain->name is set in other function, such as irq_domain_associate().

Indeed. I misread the patch, sorry. Yes that thing can go.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/