linux-kernel - RE: [PATCH v3 2/6] perf probe: Fix list result when symbol can't be found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Aug 2015 12:27:19 +0000
From:	平松雅巳 / HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>
To:	"'Wang Nan'" <wangnan0@...wei.com>,
	"acme@...nel.org" <acme@...nel.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>
CC:	"mingo@...hat.com" <mingo@...hat.com>,
	"namhyung@...nel.org" <namhyung@...nel.org>,
	"pi3orama@....com" <pi3orama@....com>,
	"lizefan@...wei.com" <lizefan@...wei.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	sysp-manager <cti.systems-productivity-manager.ts@...achi.com>
Subject: RE: [PATCH v3 2/6] perf probe: Fix list result when symbol can't be
 found

> From: Wang Nan [mailto:wangnan0@...wei.com]
> 
> 'perf probe -l' reports error if it is unable find symbol through
> address. Here is an example.
> 
>  # echo 'p:probe_libc/abs_5 /lib64/libc.so.6:0x5' >
>           /sys/kernel/debug/tracing/uprobe_events
>  # cat /sys/kernel/debug/tracing/uprobe_events
>   p:probe_libc/abs_5 /lib64/libc.so.6:0x0000000000000005
>  # perf probe -l
>    Error: Failed to show event list
> 
> Also, this situation triggers a logical inconsistency in
> convert_to_perf_probe_point() that, it returns ENOMEM but actually
> it never try strdup().
> 
> This patch removes !tp->module && !is_kprobe condition, so it
> always uses address to build function name if symbol not found.
> 
> Test result:
> 
>  # perf probe -l
>    probe_libc:abs_5     (on 0x5 in /lib64/libc.so.6)
> 

Looks good!

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

Thank you!

> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> ---
>  tools/perf/util/probe-event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 6c7e538..f7bacbb 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1866,7 +1866,7 @@ static int convert_to_perf_probe_point(struct probe_trace_point *tp,
>  	if (tp->symbol) {
>  		pp->function = strdup(tp->symbol);
>  		pp->offset = tp->offset;
> -	} else if (!tp->module && !is_kprobe) {
> +	} else {
>  		ret = e_snprintf(buf, 128, "0x%" PRIx64, (u64)tp->address);
>  		if (ret < 0)
>  			return ret;
> --
> 1.8.3.4