linux-kernel - Re: [PATCH 1/5] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Aug 2015 10:57:12 +0200
From:	Heiko Stuebner <heiko@...ech.de>
To:	Shawn Lin <shawn.lin@...k-chips.com>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	Doug Anderson <dianders@...omium.org>,
	Olof Johansson <olofj@...gle.com>,
	Sonny Rao <sonnyrao@...omium.org>,
	Addy Ke <addy.ke@...k-chips.com>, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org,
	Boojin Kim <boojin.kim@...sung.com>
Subject: Re: [PATCH 1/5] DMA: pl330: support burst mode for dev-to-mem and mem-to-dev transmit

Hi Shawn,


you're loosing the original author. Your can override the patch-author (away 
from the mail sender) via a "From:" line at the top of the commit message, 
like:

------
From: Boojin Kim <boojin.kim@...sung.com>

This patch adds to support burst mode for dev-to-mem and
mem-to-dev transmit.
...
------


> This patch adds to support burst mode for dev-to-mem and
> mem-to-dev transmit.
> 
> Signed-off-by: Boojin Kim <boojin.kim@...sung.com>
> Signed-off-by: Addy Ke <addy.ke@...k-chips.com>
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> cc: Heiko Stuebner <heiko@...ech.de>
> cc: Doug Anderson <dianders@...omium.org>
> cc: Olof Johansson <olofj@...gle.com>
> Reviewed-and-tested-by: Sonny Rao <sonnyrao@...omium.org>
> 
> ---
> 
>  drivers/dma/pl330.c | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index ecab4ea0..0d544d2 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -1141,10 +1141,13 @@ static inline int _ldst_devtomem(unsigned dry_run,
> u8 buf[], const struct _xfer_spec *pxs, int cyc)
>  {
>  	int off = 0;
> +	enum pl330_cond cond;
> +
> +	cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST;
> 
>  	while (cyc--) {
> -		off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri);
> -		off += _emit_LDP(dry_run, &buf[off], SINGLE, pxs->desc->peri);
> +		off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri);
> +		off += _emit_LDP(dry_run, &buf[off], cond, pxs->desc->peri);
>  		off += _emit_ST(dry_run, &buf[off], ALWAYS);
>  		off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri);
>  	}
> @@ -1156,11 +1159,14 @@ static inline int _ldst_memtodev(unsigned dry_run,
> u8 buf[], const struct _xfer_spec *pxs, int cyc)
>  {
>  	int off = 0;
> +	enum pl330_cond cond;
> +
> +	cond = (pxs->desc->rqcfg.brst_len == 1) ? SINGLE : BURST;
> 
>  	while (cyc--) {
> -		off += _emit_WFP(dry_run, &buf[off], SINGLE, pxs->desc->peri);
> +		off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri);
>  		off += _emit_LD(dry_run, &buf[off], ALWAYS);
> -		off += _emit_STP(dry_run, &buf[off], SINGLE, pxs->desc->peri);
> +		off += _emit_STP(dry_run, &buf[off], cond, pxs->desc->peri);
>  		off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri);
>  	}
> 
> @@ -2557,7 +2563,7 @@ static struct dma_async_tx_descriptor
> *pl330_prep_dma_cyclic(
> 
>  		desc->rqtype = direction;
>  		desc->rqcfg.brst_size = pch->burst_sz;
> -		desc->rqcfg.brst_len = 1;
> +		desc->rqcfg.brst_len = pch->burst_len;
>  		desc->bytes_requested = period_len;
>  		fill_px(&desc->px, dst, src, period_len);
> 
> @@ -2702,7 +2708,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct
> scatterlist *sgl, }
> 
>  		desc->rqcfg.brst_size = pch->burst_sz;
> -		desc->rqcfg.brst_len = 1;
> +		desc->rqcfg.brst_len = pch->burst_len;
>  		desc->rqtype = direction;
>  		desc->bytes_requested = sg_dma_len(sg);
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/