linux-kernel - RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 27 Aug 2015 09:14:47 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'Nicholas Krause'" <xerofoify@...il.com>
Cc:	<dledford@...hat.com>, <sean.hefty@...el.com>,
	<hal.rosenstock@...il.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr


> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@...il.com]
> Sent: Wednesday, August 26, 2015 7:22 PM
> To: swise@...lsio.com
> Cc: dledford@...hat.com; sean.hefty@...el.com; hal.rosenstock@...il.com; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] infiniband:cxgb4:Fix incorrect return statement in the function c4iw_reject_cr
> 
> This fixes the incorrect return statement in the function
> c4iw_reject_cr that returns the value zero directly to instead
> return the variable err as this function can fail when called
> and if so we will incorrectly return success rather then the
> correct status of a failed call to the caller of this particular
> function.
> 
> Signed-off-by: Nicholas Krause <xerofoify@...il.com>
> ---

NAK.  

The return code for these cpl handlers indicates if process_work() or other callers needs to free the skb.   They are supposed to
return 0.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/