lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 27 Aug 2015 17:49:02 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Bin Liu <binmlist@...il.com>
Cc:	linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: musb: Fix module autoload for OF platform driver

On Thu, Aug 27, 2015 at 10:41:42AM -0500, Bin Liu wrote:
> Hi,
> 
> On Thu, Aug 27, 2015 at 10:07 AM, Luis de Bethencourt
> <luis@...ethencourt.com> wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> 
> Care to add 'ux500' to the summary line - 'usb: musb: ux500: Fix...'?
> That helps filtering in git-log.
> 
> Thanks,
> -Bin.
> 

Off course. Sent a second version with 'usb: musb: ux500:' in the commit
subject.

Thanks for reviewing,
Luis

> >
> > Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> > ---
> >  drivers/usb/musb/ux500.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
> > index 39168fe..b2685e7 100644
> > --- a/drivers/usb/musb/ux500.c
> > +++ b/drivers/usb/musb/ux500.c
> > @@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
> >          {}
> >  };
> >
> > +MODULE_DEVICE_TABLE(of, ux500_match);
> > +
> >  static struct platform_driver ux500_driver = {
> >         .probe          = ux500_probe,
> >         .remove         = ux500_remove,
> > --
> > 2.4.6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ