linux-kernel - Re: [PATCH] Input: max8997_haptic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150829003106.GC8298@dtor-ws>
Date:	Fri, 28 Aug 2015 17:31:06 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-input@...r.kernel.org
Subject: Re: [PATCH] Input: max8997_haptic - Fix module alias

On Wed, Aug 26, 2015 at 02:19:41AM +0200, Javier Martinez Canillas wrote:
> The driver is a platform driver and not a I2C driver so its modalias
> should be exported with MODULE_DEVICE_TABLE(platform,...) instead of
> MODULE_DEVICE_TABLE(i2c,...).
> 
> Also, remove the unnecessary MODULE_ALIAS("platform:max8997-haptic")
> now that the correct module alias is created.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Applied, thank you.

> 
> ---
> 
>  drivers/input/misc/max8997_haptic.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/input/misc/max8997_haptic.c b/drivers/input/misc/max8997_haptic.c
> index d0f687281339..a806ba3818f7 100644
> --- a/drivers/input/misc/max8997_haptic.c
> +++ b/drivers/input/misc/max8997_haptic.c
> @@ -394,7 +394,7 @@ static const struct platform_device_id max8997_haptic_id[] = {
>  	{ "max8997-haptic", 0 },
>  	{ },
>  };
> -MODULE_DEVICE_TABLE(i2c, max8997_haptic_id);
> +MODULE_DEVICE_TABLE(platform, max8997_haptic_id);
>  
>  static struct platform_driver max8997_haptic_driver = {
>  	.driver	= {
> @@ -407,7 +407,6 @@ static struct platform_driver max8997_haptic_driver = {
>  };
>  module_platform_driver(max8997_haptic_driver);
>  
> -MODULE_ALIAS("platform:max8997-haptic");
>  MODULE_AUTHOR("Donggeun Kim <dg77.kim@...sung.com>");
>  MODULE_DESCRIPTION("max8997_haptic driver");
>  MODULE_LICENSE("GPL");
> -- 
> 2.4.3
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/