linux-kernel - Re: [BUG] Boot hangs at clocksource_done

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 31 Aug 2015 15:55:45 -0500
From:	Alex Thorlton <athorlton@....com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Alex Thorlton <athorlton@....com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Russ Anderson <rja@....com>,
	Dimitri Sivanich <sivanich@....com>
Subject: Re: [BUG] Boot hangs at clocksource_done_booting on large configs

On Mon, Aug 31, 2015 at 10:32:50PM +0200, Peter Zijlstra wrote:
> On Mon, Aug 31, 2015 at 01:04:33PM -0500, Alex Thorlton wrote:
> q
> > diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
> > index fd643d8..8502521 100644
> > --- a/kernel/stop_machine.c
> > +++ b/kernel/stop_machine.c
> > @@ -417,8 +417,11 @@ static void cpu_stopper_thread(unsigned int cpu)
> >  {
> >         struct cpu_stopper *stopper = &per_cpu(cpu_stopper, cpu);
> >         struct cpu_stop_work *work;
> > +       unsigned long flags;
> >         int ret;
> > 
> > +       local_irq_save(flags);
> > +
> >  repeat:
> >         work = NULL;
> >         spin_lock_irq(&stopper->lock);
> > @@ -452,6 +455,8 @@ repeat:
> >                 cpu_stop_signal_done(done, true);
> >                 goto repeat;
> >         }
> > +
> > +       local_irq_restore(flags);
> >  }
> > 
> 
> So I should probably just go sleep and not say anything.. _but_
> *confused*.
> 
> That local_irq_save() will disable IRQs over:
> 
> 	work = NULL;
> 
> But that is _all_. The spin_unlock_irq() will re-enable IRQs, after
> which things will run as usual.
> 
> That local_irq_restore() is a total NOP, IRQs are guaranteed enabled at
> the irq_local_save() (otherwise lockdep would've complained about
> spin_unlock_irq() unconditionally enabling them) and by the time we get
> to the restore that same unlock_irq will have enabled them already.

Ahh, right.  Well that code is worthless then :)

Either way though, I guess that means that slight change just fudged the
timing enough in that area to avoid the lockup we're seeing.  Ignoring
my useless code change, does anything else jump out at you as
interesting, here?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/