linux-kernel - Re: [PATCH v1] mm/memblock: Add memblock_first_region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 31 Aug 2015 15:58:22 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Tony Luck <tony.luck@...el.com>, Pekka Enberg <penberg@...nel.org>,
	Mel Gorman <mgorman@...e.de>, Xishi Qiu <qiuxishi@...wei.com>,
	Baoquan He <bhe@...hat.com>, Robin Holt <holt@....com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] mm/memblock: Add memblock_first_region_size() helper

On Fri, 28 Aug 2015 01:19:45 +0600 Alexander Kuleshov <kuleshovmail@...il.com> wrote:

> Some architectures (like s390, microblaze and etc...) require size
> of the first memory region. This patch provides new memblock_first_region_size()
> helper for this case.
> 
> ...
>
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -1463,6 +1463,11 @@ phys_addr_t __init_memblock memblock_end_of_DRAM(void)
>  	return (memblock.memory.regions[idx].base + memblock.memory.regions[idx].size);
>  }
>  
> +phys_addr_t __init_memblock memblock_first_region_size(void)
> +{
> +	return memblock.memory.regions[0].size;
> +}
> +
>  void __init memblock_enforce_memory_limit(phys_addr_t limit)
>  {
>  	phys_addr_t max_addr = (phys_addr_t)ULLONG_MAX;

We tend to avoid merging functions which have no callers.  Some actual
callsites should be included in the patch or patch series, please.

This is so we know it's useful, that it's getting runtime tested and to
aid review.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/