linux-kernel - Re: [PATCH 1/2] arm64: cpufeature.h: resolve hidden header dependencies

Open Source and information security mailing list archives

Date:	Tue, 1 Sep 2015 17:02:58 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	Yury Norov <ynorov@...iumnetworks.com>
Cc:	Catalin Marinas <Catalin.Marinas@....com>,
	Will Deacon <Will.Deacon@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"ddaney@...iumnetworks.com" <ddaney@...iumnetworks.com>,
	suzuki.poulose@....com
Subject: Re: [PATCH 1/2] arm64: cpufeature.h: resolve hidden header
 dependencies

On Tue, Sep 01, 2015 at 03:41:11PM +0100, Yury Norov wrote:
> Functions implemented in cpufeature.h depend on some headers, but
> cpufeature.h does not include them. This may cause build failure if
> cpufeature.h user does not include that headers by itself. (Like it
> happens in next patch of this series.)
> 
> Signed-off-by: Yury Norov <ynorov@...iumnetworks.com>
> ---
>  arch/arm64/include/asm/cpufeature.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/cpufeature.h b/arch/arm64/include/asm/cpufeature.h
> index c104421..20cdc26 100644
> --- a/arch/arm64/include/asm/cpufeature.h
> +++ b/arch/arm64/include/asm/cpufeature.h
> @@ -30,6 +30,11 @@
>  
>  #ifndef __ASSEMBLY__
>  
> +#include <linux/bitmap.h>

We're also missing <linux/compiler.h> for the __attribute_const__ on
cpuid_feature_extract_field.

> +#include <linux/log2.h>

The cpu_feature macro using ilog2 is prior to the __ASSEMBLY__ guard.
Given it cannot be used by assembly, I think it should also be pulled
under the guard, or removed as it doesn't appear to be used anyway
(which would remove the need for this include).

Otherwise this looks good to me.

Thanks,
Mark.

> +#include <linux/printk.h>
> +#include <linux/types.h>
> +
>  struct arm64_cpu_capabilities {
>  	const char *desc;
>  	u16 capability;
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives