lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Sep 2015 19:13:24 -0500 From: Rob Herring <robherring2@...il.com> To: Douglas Anderson <dianders@...omium.org> Cc: Heiko Stuebner <heiko@...ech.de>, linux-rockchip@...ts.infradead.org, Alexandru Stan <amstan@...omium.org>, briannorris@...omium.org, Yakir Yang <ykk@...k-chips.com>, 姚智情 <mark.yao@...k-chips.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Russell King - ARM Linux <linux@....linux.org.uk>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] ARM: dts: Add ddc i2c reference to veyron On Wed, Sep 2, 2015 at 4:25 PM, Douglas Anderson <dianders@...omium.org> wrote: > The ddc-i2c-bus property was missing from the veyron dtsi file since > downstream the ddc-i2c-bus was still being specified in rk3288.dtsi and > nobody noticed when the veyron dtsi was sent upstream. Add it. > > Signed-off-by: Douglas Anderson <dianders@...omium.org> > --- > Note: I noticed that this was wrong but I don't currently have > graphics up and running on upstream on veyron. Posting this anyway > since it's pretty clear that it's needed. If someone else wants to > try it out that'd be nice, otherwise I'll put it on my list to figure > out how to get myself setup for graphics upstream. ;) Based on your other patch, this is temporary, right? I've been looking at DRM a lot lately. I think specifying the i2c bus in the hdmi chip or IP block node is wrong. If the I2C host is separate from the HDMI block, then it's only connection is to the HDMI connector. So the I2C host to the connector relationship is what the DT should describe. HPD gpio is similar. Now if the HDMI bridge controls DDC and HPD directly, then we don't need to describe those connections. Rob > > arch/arm/boot/dts/rk3288-veyron.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > index 2fa7a0d..275c78c 100644 > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > @@ -158,6 +158,7 @@ > }; > > &hdmi { > + ddc-i2c-bus = <&i2c5>; > status = "okay"; > }; > > -- > 2.5.0.457.gab17608 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists