linux-kernel - Re: [PATCH 1/2] mfd: Fixup clients of multi_reg_write/register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 Sep 2015 16:08:06 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Nariman Poushin <nariman@...nsource.wolfsonmicro.com>,
	Mark Brown <broonie@...nel.org>,
	Lee Jones <lee.jones@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Linux-Next <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 1/2] mfd: Fixup clients of multi_reg_write/register_patch

On Mon, Jul 20, 2015 at 3:59 AM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> On Fri, 17 Jul 2015 15:09:26 +0100 Nariman Poushin <nariman@...nsource.wolfsonmicro.com> wrote:
>> Introduced by:
>> commit 8019ff6cfc04
>> ("regmap: Use reg_sequence for multi_reg_write / register_patch")
>>
>> Interacting with:
>> commit 561629755a21 ("mfd: arizona: Add support for WM8998 and WM1814")
>> commit 81207880cef2 ("mfd: wm5110: Add register patch for rev E and above")
>>
>> Signed-off-by: Nariman Poushin <nariman@...nsource.wolfsonmicro.com>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

>> ---
>>  drivers/mfd/wm5110-tables.c | 2 +-
>>  drivers/mfd/wm8998-tables.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> I will apply both these patches as merge fix patches in linux-next
> today.  Thanks.

7 weeks later, the fix is still in -next only, hidden in:

commit 203903b3383c2dc8bcommit 203903b3383c2dc8b79277061341ec1c31ea75e3
Merge: f7ef70b70ccf13a9 90b1f7f5d2016031
Author: Stephen Rothwell <sfr@...b.auug.org.au>
Date:   Thu Sep 3 12:39:52 2015 +1000

    Merge remote-tracking branch 'regmap/for-next'

Worse, the problem is now in Linus' tree:

drivers/mfd/wm5110-tables.c: In function ‘wm5110_patch’:
drivers/mfd/wm5110-tables.c:281: warning: passing argument 2 of
‘regmap_register_patch’ from incompatible pointer type
drivers/mfd/wm8998-tables.c: In function ‘wm8998_patch’:
drivers/mfd/wm8998-tables.c:50: warning: passing argument 2 of
‘regmap_register_patch’ from incompatible pointer type

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/