linux-kernel - Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 05 Sep 2015 22:02:27 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Cc:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine

Ezequiel Garcia <ezequiel@...guardiasur.com.ar> writes:

> Robert,
>
> Just a couple of minor comments.
>> +	dma_unmap_sg(info->dma_chan->device->dev,
>> +		     &info->sg, 1, info->dma_dir);
>
> Unneeded line breaking.
Indeed, for v2.

>> +		r = platform_get_resource(pdev, IORESOURCE_DMA, 1);
>> +		if (r == NULL) {
>> +			dev_err(&pdev->dev,
>> +				"no resource defined for cmd DMA\n");
>> +			ret = -ENXIO;
>> +			goto fail_disable_clk;
>> +		}
>> +		info->drcmr_cmd = r->start;
>
> AFAICS, you only do data DMA, so this command resource can go away.
> If you want to keep it for now and remove it as a follow up patch,
> that's fine.
Yeah, keep it in this patch, and change in a future patch (ie. keep current
behavior).

> Other than this minor stuff:
>
> Reviewed-by: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
> Tested-by: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Thanks, I'll add that in v2.

> Tested on Armada 370 to make sure it doesn't cause any regressions.
Good. Was it on top of linux-next or linux master ?

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/