linux-kernel - Re: [PATCH] staging: slicoss: remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 5 Sep 2015 13:38:56 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	David Matlack <dmatlack@...gle.com>
Cc:	Lior Dotan <liodot@...il.com>,
	Christopher Harrer <charrer@...critech.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: slicoss: remove unused variables

On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote:
> On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> > These variables were only assigned some values but they were never used.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
<snip>
> > -       status = slic_upr_request(adapter, SLIC_UPR_RLSR,
> > -               (u32) &pshmem->linkstatus,      /* no 4GB wrap guaranteed */
> > -                                 0, 0, 0);
> > +       slic_upr_request(adapter, SLIC_UPR_RLSR,
> > +                        (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */
> > +                        0, 0, 0);
> 
> Is status safe to ignore?
status can have two value either -ENOMEM or STATUS_PEMDING.
Ideally we should have handled -ENOMEM.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/