linux-kernel - Re: [PATCH 01/01] kdbus: Eliminate warning caused by lack of uapi/linux/kdbus.h inclusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Sep 2015 14:54:01 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Paul Osmialowski <p.osmialowsk@...sung.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	Paul Moore <pmoore@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Lukasz Pawelczyk <l.pawelczyk@...sung.com>
Subject: Re: [PATCH 01/01] kdbus: Eliminate warning caused by lack of
 uapi/linux/kdbus.h inclusion

Hi

On Tue, Sep 8, 2015 at 2:48 PM, Paul Osmialowski
<p.osmialowsk@...sung.com> wrote:
> metadata.h references struct kdbus_pids which is defined in
> uapi/linux/kdbus.h
>
> Normally, kdbus/metadata.h is included after many other headers
> that eventually include uapi/linux/kdbus.h at some point (e.g. kdbus/bus.h
> includes uapi/linux/kdbus.h), this prevents the warning.
>
> When included alone, it causes warning. Also when kdbus/connection.h
> is included alone, the same warning is shown since kdbus/connection.h
> includes kdbus/metadata.h.
>
> This patch adds missing inclusion.
>
> Signed-off-by: Paul Osmialowski <p.osmialowsk@...sung.com>
> ---
>  ipc/kdbus/metadata.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: David Herrmann <dh.herrmann@...il.com>

Thanks
David

> diff --git a/ipc/kdbus/metadata.h b/ipc/kdbus/metadata.h
> index dba7cc7..3f9ba38 100644
> --- a/ipc/kdbus/metadata.h
> +++ b/ipc/kdbus/metadata.h
> @@ -16,6 +16,7 @@
>  #define __KDBUS_METADATA_H
>
>  #include <linux/kernel.h>
> +#include <uapi/linux/kdbus.h>
>
>  struct kdbus_conn;
>  struct kdbus_pool_slice;
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/