linux-kernel - Re: [PATCH 3/5] staging: most: remove driver owner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Sep 2015 09:48:37 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Andrey Shvetsov <andrey.shvetsov@....de>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] staging: most: remove driver owner

On Tue, Sep 08, 2015 at 11:56:29AM +0200, Andrey Shvetsov wrote:
> On Mon, Sep 07, 2015 at 06:16:21PM +0530, Sudip Mukherjee wrote:
> > On Mon, Sep 07, 2015 at 02:13:38PM +0200, Andrey Shvetsov wrote:
> > > On Fri, Sep 04, 2015 at 04:22:04PM +0530, Sudip Mukherjee wrote:
> > > > The platform driver core will set the owner value, we do not need to do
> > > > it in the module.
> > > > 
> > > > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > > > ---
> > > >  drivers/staging/most/hdm-dim2/dim2_hdm.c | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/staging/most/hdm-dim2/dim2_hdm.c b/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > > > index 5b0a588..4481a0b 100644
> > > > --- a/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > > > +++ b/drivers/staging/most/hdm-dim2/dim2_hdm.c
> > > > @@ -923,7 +923,6 @@ static struct platform_driver dim2_driver = {
> > > >  	.id_table = dim2_id,
> > > >  	.driver = {
> > > >  		.name = "hdm_dim2",
> > > > -		.owner = THIS_MODULE,
> > > I cannot accept this.
> > > 
> > > This change is not significant for current kernel, but we still have customers
> > > using kernels <= 3.10, where auto assignment of .owner does not exist.
> > But this patch is for 4.4-rc1, and it is not marked for stable. Then how
> > is it going to affect your customers who are still using <=3.10?
> The customers will get MOST Linux Driver of 4.x and compile it with 3.10.

Really?  If they do that they are on their own and odds are, it will
break.

> They'll not even see the warning, but missing owner is definitely not what they
> want to have.  This patch prepares wasted time of cusomers expiriencing the
> issue and ours supporting resolving of some problem.  But what we get instead?

We do not support people taking a kernel driver from one kernel and
putting it into another one.  That's never been something that anyone
can ever do with Linux, sorry.

The patch is correct.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/