linux-kernel - Re: [PATCH v3] Cleanup: membarrier selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2015 18:36:44 +1000
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
	Pranith Kumar <bobby.prani@...il.com>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v3] Cleanup: membarrier selftest

On Tue, 2015-09-08 at 16:58 -0400, Mathieu Desnoyers wrote:
> We don't need to specify an explicit rule in the Makefile, the implicit
> one will do the same. The "__EXPORTED_HEADERS__" define is not needed,
> because we build the test against the installed kernel headers, not the
> in-tree kernel headers. Re-use "$(TEST_PROGS)" in the clean target
> rather than spelling the executable name twice. Include <unistd.h>
> rather than the rather specific <asm-generic/unistd.h>. Include
> <syscall.h> rather than <sys/syscall.h>. In both cases, the former
> header is located in a standard location and includes the latter.
> 
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> CC: Michael Ellerman <mpe@...erman.id.au>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: linux-api@...r.kernel.org
> CC: Pranith Kumar <bobby.prani@...il.com>
> CC: Shuah Khan <shuahkh@....samsung.com>
> --
> Changes since v2:
> - Refine Changelog, removing references to comments, taking care
>   of comments from Shuah Khan.
> Changes since v1:
> - Add Changelog.
> Changes since RFC:
> - Take care of comments from Michael Ellerman.

Looks great, thanks.

Acked-by: Michael Ellerman <mpe@...erman.id.au>

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/