[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 9 Sep 2015 03:23:27 +0200
From: Petr Cvek <petr.cvek@....cz>
To: Robert Jarzmik <robert.jarzmik@...e.fr>,
Samuel Ortiz <samuel@...tiz.org>,
Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 2/3] net: irda: pxaficp_ir: convert to readl and writel
Dne 8.9.2015 v 22:24 Petr Cvek napsal(a):
>
> Did you defined resources somewhere? Actual resources are in "pxa_ir_resources" variable at:
>
> http://lxr.free-electrons.com/source/arch/arm/mach-pxa/devices.c#L386
>
> or this pdata should be moved into specific machine files?
>
I tried to add following patch for new resources, but now it fails with:
[ 141.534545] pxa2xx-ir pxa2xx-ir: can't request region for resource [mem 0x40700000-0x40700100]
[ 141.534574] pxa2xx-ir pxa2xx-ir: resource stuart not defined
[ 141.534656] pxa2xx-ir: probe of pxa2xx-ir failed with error -16
That's because STUART is allocated by normal UART driver at:
http://lxr.free-electrons.com/source/arch/arm/mach-pxa/devices.c#L244
So somehow there must be configuration for STUART used with FICP and STUART alone (probably can be used for normal UART).
diff --git a/arch/arm/mach-pxa/devices.c b/arch/arm/mach-pxa/devices.c
index 3543466..316ffa3 100644
--- a/arch/arm/mach-pxa/devices.c
+++ b/arch/arm/mach-pxa/devices.c
@@ -394,6 +394,26 @@ static struct resource pxa_ir_resources[] = {
.end = IRQ_ICP,
.flags = IORESOURCE_IRQ,
},
+ [2] = {
+ .start = 0x40800000,
+ .end = 0x40800000 + 0x100,
+ .flags = IORESOURCE_MEM,
+ },
+ [3] = {
+ .start = 0x40700000,
+ .end = 0x40700000 + 0x100,
+ .flags = IORESOURCE_MEM,
+ },
+ [4] = {
+ .start = 17,
+ .end = 17,
+ .flags = IORESOURCE_DMA,
+ },
+ [5] = {
+ .start = 18,
+ .end = 18,
+ .flags = IORESOURCE_DMA,
+ },
};
struct platform_device pxa_device_ficp = {
--
1.7.12.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists