linux-kernel - Re: [PATCH v12 07/21] x86/xen: Add stack frame dependency to hypercall inline asm calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Sep 2015 14:30:27 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Josh Poimboeuf <jpoimboe@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, <x86@...nel.org>
CC:	<linux-kernel@...r.kernel.org>, <live-patching@...r.kernel.org>,
	"Michal Marek" <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	"Andy Lutomirski" <luto@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	"Pedro Alves" <palves@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	"Bernd Petrovitsch" <bernd@...rovitsch.priv.at>,
	Chris J Arges <chris.j.arges@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Subject: Re: [PATCH v12 07/21] x86/xen: Add stack frame dependency to hypercall
 inline asm calls

On 09/09/15 14:21, Josh Poimboeuf wrote:
> If a hypercall is inlined at the beginning of a function, gcc can insert
> the call instruction before setting up a stack frame, which breaks frame
> pointer convention if CONFIG_FRAME_POINTER is enabled and can result in
> a bad stack trace.
> 
> Force a stack frame to be created if CONFIG_FRAME_POINTER is enabled by
> listing the stack pointer as an output operand for the hypercall inline
> asm statements.

Reviewed-by: David Vrabel <david.vrabel@...rix.com>

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/