[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 9 Sep 2015 17:03:46 +0200
From: Clément Vuchener <clement.vuchener@...il.com>
To: jikos@...nel.org
Cc: linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-input@...r.kernel.org
Subject: Re: [PATCH v2 0/1] Corsair Vengeance K90 driver
On Mon, Sep 07, 2015 at 05:58:36PM +0200, Clément Vuchener wrote:
> I removed the k90_profile class completely. I cannot write a good enough ABI with what I know of the keyboard so I am leaving that part out of the kernel. If I change my mind in the future, it will be done in another patch.
>
> I also fixed a bug I had when unregistering the led device. Work was being scheduled after the led device was unregistered.
>
> On the name change, I kept a lot of K90 references. As far as I know, the only similar keyboard is the K60 that shares the same firmware but does not have all the special keys and backlight, and for which the hid-generic driver should be enough. The more recent RGB keyboard series uses a different protocol from what I have seen from the unofficial userspace driver (CKB from MSC).
Actually, I may have been wrong, other keyboard may share at least the incorrect HID usage code part. I will investigate more and send a new patch. I am still interested in comments on this one, especially on the choice of key codes for the programmable keys.
>
> changes in v2:
> - Removed the k90_profile class and devices
> - Renamed driver for a more generic name ("corsair" driver in hid-corsair.c)
> - Fixed led devices clean up (hang when unplugging and led state reset)
> - Added dependency on USB and LEDS_CLASS in Kconfig
>
> Clément Vuchener (1):
> Add Corsair Vengeance K90 driver
>
> Documentation/ABI/testing/sysfs-driver-hid-corsair | 15 +
> drivers/hid/Kconfig | 10 +
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-core.c | 1 +
> drivers/hid/hid-corsair.c | 555 +++++++++++++++++++++
> drivers/hid/hid-ids.h | 3 +
> 6 files changed, 585 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-corsair
> create mode 100644 drivers/hid/hid-corsair.c
>
> --
> 2.4.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists