linux-kernel - Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 10 Sep 2015 01:47:50 +0300
From:	Alexey Klimov <klimov.linux@...il.com>
To:	Ramakrishna Pallala <ramakrishna.pallala@...el.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
	Sebastian Reichel <sre@...nel.org>,
	Jenny TC <jenny.tc@...el.com>,
	Andreas Dannenberg <dannenberg@...com>
Subject: Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Ramakrishna,

On Sun, Sep 6, 2015 at 8:23 PM, Ramakrishna Pallala
<ramakrishna.pallala@...el.com> wrote:
> Add new charger driver support for BQ24261 charger IC.
>
> BQ24261 charger driver relies on extcon notifications to get the
> charger cable type and based on that it will set the charging parameters.
>
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@...el.com>
> Signed-off-by: Jennt TC <jenny.tc@...el.com>
> ---
>  .../devicetree/bindings/power/bq24261.txt          |   37 +
>  drivers/power/Kconfig                              |    6 +
>  drivers/power/Makefile                             |    1 +
>  drivers/power/bq24261_charger.c                    | 1208 ++++++++++++++++++++

[..]

> +static int bq24261_probe(struct i2c_client *client,
> +                        const struct i2c_device_id *id)
> +{
> +       struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> +       struct power_supply_config charger_cfg = {};
> +       struct bq24261_charger *chip;
> +       int ret;
> +       enum bq2426x_model model;
> +
> +       adapter = to_i2c_adapter(client->dev.parent);

Please also check if you really need to call to_i2c_adapter() twice.

-- 
Best regards, Klimov Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/