linux-kernel - Re: [PATCH] net: stmmac: Use msleep rather then udelay for reset delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 08 Sep 2015 22:40:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sjoerd.simons@...labora.co.uk
Cc:	peppe.cavallaro@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: stmmac: Use msleep rather then udelay for reset
 delay

From: Sjoerd Simons <sjoerd.simons@...labora.co.uk>
Date: Sun,  6 Sep 2015 17:50:59 +0200

> @@ -161,11 +161,16 @@ int stmmac_mdio_reset(struct mii_bus *bus)
>  
>  		if (!gpio_request(reset_gpio, "mdio-reset")) {
>  			gpio_direction_output(reset_gpio, active_low ? 1 : 0);
> -			udelay(data->delays[0]);
> +			if (data->delays[0])
> +				msleep((data->delays[0] + 999) / 1000);

Please use something like DIV_ROUND_UP(..., USEC_PER_MSEC) or similar.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/