linux-kernel - RE: [PATCH 1/3] perf probe: Free perf probe event in cleanup_perf_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Sep 2015 08:51:25 +0000
From:	平松雅巳 / HIRAMATU，MASAMI 
	<masami.hiramatsu.pt@...achi.com>
To:	"'Namhyung Kim'" <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
CC:	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Wang Nan <wangnan0@...wei.com>
Subject: RE: [PATCH 1/3] perf probe: Free perf probe event in
 cleanup_perf_probe_events()

Hi Namhyung,

>From: Namhyung Kim [mailto:namhyung@...il.com] On Behalf Of Namhyung Kim
>Sent: Thursday, September 10, 2015 11:27 AM
>To: Arnaldo Carvalho de Melo
>Cc: Ingo Molnar; Peter Zijlstra; Jiri Olsa; LKML; Wang Nan; 平松雅巳 / HIRAMATU，MASAMI
>Subject: [PATCH 1/3] perf probe: Free perf probe event in cleanup_perf_probe_events()
>
>The cleanup_perf_probe_events() frees all resources related to a perf
>probe event.  However it only freed resources in trace probe events, not
>perf probe events.  So call clear_perf_probe_event() too.

This looks good to me :)

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

Thanks!


>
>Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
>Reported-by: Wang Nan <wangnan0@...wei.com>
>Signed-off-by: Namhyung Kim <namhyung@...nel.org>
>---
> tools/perf/util/probe-event.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
>index 5964eccbe94d..3d7d60cc6f16 100644
>--- a/tools/perf/util/probe-event.c
>+++ b/tools/perf/util/probe-event.c
>@@ -2792,6 +2792,7 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs)
> 			clear_probe_trace_event(&pevs[i].tevs[j]);
> 		zfree(&pevs[i].tevs);
> 		pevs[i].ntevs = 0;
>+		clear_perf_probe_event(&pevs[i]);
> 	}
>
> 	exit_symbol_maps();
>--
>2.5.0