linux-kernel - Re: [PATCH] ASoC: make dapm cache search depth configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Sep 2015 10:42:50 +0100
From:	Nikesh <noswal@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>,
	Nikesh Oswal <nikesh@...nsource.wolfsonmicro.com>
CC:	<lgirdwood@...il.com>, <perex@...ex.cz>, <tiwai@...e.de>,
	<alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
	<patches@...nsource.wolfsonmicro.com>, <Nikesh.Oswal@...rus.com>
Subject: Re: [PATCH] ASoC: make dapm cache search depth configurable

Hi Mark,

The reason I though this will be usefull is as below:

While adding paths the source or sink widgets of consecutive path that 
are being added, may not be immediate neighbours in widget list. Hence 
in such scenarios the cache hits will reduce. One possible solution is 
to rearrange the widgets in the codec driver but sometimes
codec driver uses some macros to create a bunch of related widgets which 
we may want to skip in the cache search. So a configurable cache search 
depth caters to such scenarios.

For example in wm5110.c the frequently occuring mixer routes are defined 
by ARIZONA_MIXER_INPUT_ROUTES, so as to maximise the cache hit codec 
driver can register all the source widgets in exactly the same order (by 
rearranging the widgets in wm5110_dapm_widgets[]) as defined in this 
macro. But if you notice the way DSP widgets are created they use a 
WM_ADSP2 macro which creates a preloader widget for every DSP widget and 
we want to skip past this preloader widget when doing a cache search so 
increasing the cache search depth helps here.

Thanks,
Nikesh

On 08/09/15 11:42, Mark Brown wrote:
> On Tue, Sep 08, 2015 at 11:11:37AM +0100, Nikesh Oswal wrote:
>> cache search depth will have a default value of 2 and can
>> be modified by the respective component probe function
> Why?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/