linux-kernel - Re: [PATCH v4 1/8] i2c: Add pointer dereference protection to i2c_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 11 Sep 2015 10:48:44 +0100
From:	Kieran Bingham <kieranbingham@...il.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...aro.org>
Subject: Re: [PATCH v4 1/8] i2c: Add pointer dereference protection to i2c_match_id()

Hi Lee,

On 11 September 2015 at 10:31, Lee Jones <lee.jones@...aro.org> wrote:
> On Wed, 09 Sep 2015, Kieran Bingham wrote:
>
>> From: Lee Jones <lee.jones@...aro.org>
>>
>> Here we're providing dereference protection for i2c_match_id(), which
>> saves us having to do it each time it's called.  We're also stripping
>> out the (now) needless checks in i2c_device_match().  This patch paves
>> the way for other, similar code trimming.
>>
>> Acked-by: Grant Likely <grant.likely@...aro.org>
>> Signed-off-by: Lee Jones <lee.jones@...aro.org>
>
> SoB?


My apologies, I only added SOB to the patches I had modified ...
I didn't realise it should go on the ones I didn't touch as well.

I'll update and resend.

--
Regards

>
>> ---
>>  drivers/i2c/i2c-core.c | 12 +++++++-----
>>  1 file changed, 7 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
>> index c83e4d1..30d8a77 100644
>> --- a/drivers/i2c/i2c-core.c
>> +++ b/drivers/i2c/i2c-core.c
>> @@ -450,6 +450,9 @@ static inline int acpi_i2c_install_space_handler(struct i2c_adapter *adapter)
>>  static const struct i2c_device_id *i2c_match_id(const struct i2c_device_id *id,
>>                                               const struct i2c_client *client)
>>  {
>> +     if (!(id && client))
>> +             return NULL;
>> +
>>       while (id->name[0]) {
>>               if (strcmp(client->name, id->name) == 0)
>>                       return id;
>> @@ -463,8 +466,6 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
>>       struct i2c_client       *client = i2c_verify_client(dev);
>>       struct i2c_driver       *driver;
>>
>> -     if (!client)
>> -             return 0;
>>
>>       /* Attempt an OF style match */
>>       if (of_driver_match_device(dev, drv))
>> @@ -475,9 +476,10 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv)
>>               return 1;
>>
>>       driver = to_i2c_driver(drv);
>> -     /* match on an id table if there is one */
>> -     if (driver->id_table)
>> -             return i2c_match_id(driver->id_table, client) != NULL;
>> +
>> +     /* Finally an I2C match */
>> +     if (i2c_match_id(driver->id_table, client))
>> +             return 1;
>>
>>       return 0;
>>  }
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/