linux-kernel - Re: [PATCH 2/2] ARM: dts: rockchip: Add dtb for the Radxa Rock 2 Square board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Sep 2015 09:50:20 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Sjoerd Simons <sjoerd.simons@...labora.co.uk>
Cc:	Heiko Stuebner <heiko@...ech.de>,
	Mark Rutland <mark.rutland@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-rockchip@...ts.infradead.org,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: Add dtb for the Radxa Rock 2
 Square board

Hello Sjoerd,

On Mon, Sep 14, 2015 at 9:30 AM, Sjoerd Simons
<sjoerd.simons@...labora.co.uk> wrote:

[snip]

>> > +
>> > +                       vcc18_lcd: REG12 {
>> > +                               regulator-name = "VCC18_LCD";
>> > +                               regulator-min-microvolt =
>> > <1800000>;
>> > +                               regulator-max-microvolt =
>> > <1800000>;
>> > +                               regulator-always-on;
>> > +                       };
>>
>> Should all these regulators really need to be always-on?
>
> Ideally not all of them, turning the ones that aren't needed off is
> definately on my list of things to do (together with the other
> pheripherals, leds, hw. keys etc).
>
> For the first patch i do prefer to keep them on so we can have get some
> more testing  with this board before fine-tuning those things (fwiw,

Ok.

> the rockchip evb board and others with essentially the same pmic setup
> all also have them always-on)

Yes but I believe that's because it was easier and there are
regulators on these boards that don't need to be always-on as well.

> --
> Sjoerd Simons
> Collabora Ltd.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/