linux-kernel - Re: [PATCH RFC 6/8] drm: hisilicon: Add support for fbdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2015 13:25:37 -0500
From:	Rob Herring <robh@...nel.org>
To:	Xinwei Kong <kong.kongxinwei@...ilicon.com>, airlied@...ux.ie,
	corbet@....net, catalin.marinas@....com, will.deacon@....com
Cc:	dri-devel@...ts.freedesktop.org, linux-doc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linuxarm@...wei.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	xinliang.liu@...aro.org, andy.green@...aro.org,
	qijiwen@...ilicon.com, gongyu@...ilicon.com,
	haojian.zhuang@...aro.org, liguozhu@...ilicon.com,
	xuwei5@...ilicon.com, yinshengbao@...ilicon.com,
	yanhaifeng@...ilicon.com, ml.yang@...ilicon.com, yimin@...wei.com,
	w.f@...wei.com, puck.chen@...ilicon.com, bintian.wang@...wei.com,
	benjamin.gaignard@...aro.org, xuyiping@...ilicon.com,
	james.yanglong@...ilicon.com, fangdechun@...ilicon.com
Subject: Re: [PATCH RFC 6/8] drm: hisilicon: Add support for fbdev

On 09/15/2015 04:37 AM, Xinwei Kong wrote:
> If you config DRM_HISI_FBDEV optional, this patch will only support fbdev
> mode while also supporting double buffer.

This is a lot of duplicated code from CMA fbdev. Is double buffering the
only reason why CMA fbdev can't be used or are there some other
constraints? Double buffering in fbdev has always been a hack, so I'm
guessing that is not a feature that should be added here.

Rob

> Signed-off-by: Xinliang Liu <xinliang.liu@...aro.org>
> Signed-off-by: Xinwei Kong <kong.kongxinwei@...ilicon.com>
> Signed-off-by: Andy Green <andy.green@...aro.org>
> Signed-off-by: Jiwen Qi <qijiwen@...ilicon.com>
> Signed-off-by: Yu Gong <gongyu@...ilicon.com>
> ---
>  drivers/gpu/drm/hisilicon/Kconfig              |  13 +
>  drivers/gpu/drm/hisilicon/Makefile             |   3 +-
>  drivers/gpu/drm/hisilicon/hisi_drm_connector.c |   4 +
>  drivers/gpu/drm/hisilicon/hisi_drm_drv.c       |   9 +
>  drivers/gpu/drm/hisilicon/hisi_drm_dsi.c       |  15 +
>  drivers/gpu/drm/hisilicon/hisi_drm_fb.h        |   5 +
>  drivers/gpu/drm/hisilicon/hisi_drm_fbdev.c     | 395 +++++++++++++++++++++++++
>  drivers/gpu/drm/hisilicon/hisi_drm_fbdev.h     |  24 ++
>  8 files changed, 467 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/gpu/drm/hisilicon/hisi_drm_fbdev.c
>  create mode 100644 drivers/gpu/drm/hisilicon/hisi_drm_fbdev.h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/