linux-kernel - Re: [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 16 Sep 2015 11:53:11 +0200
From:	Andrzej Hajda <a.hajda@...sung.com>
To:	Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghua.yu@...el.com>
Cc:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	linux-kernel@...r.kernel.org, linux-ia64@...r.kernel.org
Subject: Re: [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating
 its implementation

Ping.

Regards
Andrzej

On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
> ---
>  arch/ia64/sn/pci/tioce_provider.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> index 46d3df4..2f13276 100644
> --- a/arch/ia64/sn/pci/tioce_provider.c
> +++ b/arch/ia64/sn/pci/tioce_provider.c
> @@ -1000,11 +1000,11 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
>  	 * Allocate kernel bus soft and copy from prom.
>  	 */
>  
> -	tioce_common = kzalloc(sizeof(struct tioce_common), GFP_KERNEL);
> +	tioce_common = kmemdup(prom_bussoft, sizeof(struct tioce_common),
> +			       GFP_KERNEL);
>  	if (!tioce_common)
>  		return NULL;
>  
> -	memcpy(tioce_common, prom_bussoft, sizeof(struct tioce_common));
>  	tioce_common->ce_pcibus.bs_base = (unsigned long)
>  		ioremap(REGION_OFFSET(tioce_common->ce_pcibus.bs_base),
>  			sizeof(struct tioce_common));

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/