linux-kernel - Re: [PATCH] staging: wilc1000: Removed unwanted curly braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 16 Sep 2015 23:18:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Aparna Karuthodi <kdasaparna@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wilc1000: Removed unwanted curly braces

On Wed, Sep 16, 2015 at 09:50:50PM +0530, Aparna Karuthodi wrote:
> Removed unwanted curly braces of a single statement if-else block to
> remove a coding style warning detected by checkpatch. The warning is
> given below:
> 
> 58: WARNING: braces {} are not necessary for any arm of this statement
> 
> Signed-off-by: Aparna Karuthodi <kdasaparna@...il.com>
> ---
>  drivers/staging/wilc1000/fifo_buffer.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/fifo_buffer.c b/drivers/staging/wilc1000/fifo_buffer.c
> index b6c07cf..4fbac3d 100644
> --- a/drivers/staging/wilc1000/fifo_buffer.c
> +++ b/drivers/staging/wilc1000/fifo_buffer.c
> @@ -52,11 +52,10 @@ u32 FIFO_ReadBytes(tHANDLE hFifo, u8 *pu8Buffer, u32 u32BytesToRead, u32 *pu32By
>  		if (pstrFifoHandler->u32TotalBytes) {
>  			down(&pstrFifoHandler->SemBuffer);
>  
> -			if (u32BytesToRead > pstrFifoHandler->u32TotalBytes) {
> +			if (u32BytesToRead > pstrFifoHandler->u32TotalBytes)
>  				*pu32BytesRead = pstrFifoHandler->u32TotalBytes;
> -			} else {
> +			 else

The indenting is wrong here.  There is an extra space char.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/