lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 20 Sep 2015 22:26:25 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: "K. Y. Srinivasan" <kys@...rosoft.com> Cc: linux-kernel@...r.kernel.org, devel@...uxdriverproject.org, olaf@...fle.de, apw@...onical.com, vkuznets@...hat.com, jasowang@...hat.com Subject: Re: [PATCH 4/5] hv: kvp: use wrappers to propaigate state On Tue, Sep 15, 2015 at 05:37:53PM -0700, K. Y. Srinivasan wrote: > From: Olaf Hering <olaf@...fle.de> > > The "state" is used by several threads of execution. > Propagate the state to make changes visible. Also propagate context > change in kvp_on_msg. > > Signed-off-by: Olaf Hering <olaf@...fle.de> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com> > --- > drivers/hv/hv_kvp.c | 39 +++++++++++++++++++++------------------ > 1 files changed, 21 insertions(+), 18 deletions(-) > > diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c > index 74c38a9..778d353 100644 > --- a/drivers/hv/hv_kvp.c > +++ b/drivers/hv/hv_kvp.c > @@ -61,7 +61,7 @@ > */ > > static struct { > - int state; /* hvutil_device_state */ > + enum hvutil_device_state state; > int recv_len; /* number of bytes received. */ > struct hv_kvp_msg *kvp_msg; /* current message */ > struct vmbus_channel *recv_channel; /* chn we got the request */ > @@ -74,6 +74,9 @@ static struct { > */ > static int dm_reg_value; > > +#define kvp_get_state() hvutil_device_get_state(&kvp_transaction.state) > +#define kvp_set_state(s) hvutil_device_set_state(&kvp_transaction.state, s) > + > static void kvp_send_key(struct work_struct *dummy); > > > @@ -122,8 +125,8 @@ static void kvp_timeout_func(struct work_struct *dummy) > kvp_respond_to_host(NULL, HV_E_FAIL); > > /* Transaction is finished, reset the state. */ > - if (kvp_transaction.state > HVUTIL_READY) > - kvp_transaction.state = HVUTIL_READY; > + if (kvp_get_state() > HVUTIL_READY) > + kvp_set_state(HVUTIL_READY); > And what if the state changed the line after this? Oops, your code is hosed. See, you need a lock, do this correctly. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists