linux-kernel - Re: [PATCH] kexec: Add prefix "kexec" to output message

Open Source and information security mailing list archives

Date:	Wed, 23 Sep 2015 10:49:33 +0800
From:	Baoquan He <bhe@...hat.com>
To:	Dave Young <dyoung@...hat.com>
Cc:	Minfei Huang <mhuang@...hat.com>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, kexec@...ts.infradead.org,
	Minfei Huang <mnfhuang@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] kexec: Add prefix "kexec" to output message

On 09/23/15 at 09:37am, Dave Young wrote:
> > > Hi, Dave.
> > > 
> > > How about removing all of the prefix "crashkernel" in kexec_core. Thus
> > > we can be consistent with the output message prefix "kexec".
> > 
> > Ping, any comment is appreciate and helpful.
> 
> Remove "crashkernel" sounds not a proper way, it indicates crashkernel parsing
> messages. I have no idea what is the best way but below modification sounds better to me:
> 
> kexec_core.c:
> 
> #define pr_fmt(fmt)        "[kexec_core] " fmt
> Also remove below prefix "Kexec:"
> pr_warn("Kexec: Memory allocation for saving cpu register states failed\n"); 
> 
> kexec.c:
> #define pr_fmt(fmt)        "[kexec] " fmt
> 
> kexec_file.c:
> #define pr_fmt(fmt)        "[kexec_file] " fmt

This is weird, user really don't need to know each file. I saw you added
a new file kexec_internal.h and all three files includes it. Why not doing
it there to make it the same as before?

> 
> Thanks
> Dave
> 
> _______________________________________________
> kexec mailing list
> kexec@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives