linux-kernel - Re: [PATCH v2 3/6] staging: fsl-mc: up-rev dpbp binary interface to v2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Sep 2015 20:08:01 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"J. German Rivera" <German.Rivera@...escale.com>
Cc:	arnd@...db.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, stuart.yoder@...escale.com,
	bhupesh.sharma@...escale.com, agraf@...e.de,
	bhamciu1@...escale.com, nir.erez@...escale.com,
	itai.katz@...escale.com, scottwood@...escale.com,
	leoli@...escale.com, R89243@...escale.com,
	dan.carpenter@...cle.com, richard.schmitt@...escale.com
Subject: Re: [PATCH v2 3/6] staging: fsl-mc: up-rev dpbp binary interface to
 v2.0

On Tue, Sep 22, 2015 at 06:08:56PM -0500, J. German Rivera wrote:
> Add cmd_flags parameter to all dpbp APIs to comply
> with the dpbp 2.0 MC interface. Updated MC version
> major number. Pass irq args in struct instead of
> separate args.
> 
> Signed-off-by: J. German Rivera <German.Rivera@...escale.com>
> ---
>  drivers/staging/fsl-mc/bus/dpbp.c         | 136 ++++++++++++++++++++----------
>  drivers/staging/fsl-mc/include/dpbp-cmd.h |   2 +-
>  drivers/staging/fsl-mc/include/dpbp.h     |  91 +++++++++++++++-----
>  3 files changed, 162 insertions(+), 67 deletions(-)
> 
> diff --git a/drivers/staging/fsl-mc/bus/dpbp.c b/drivers/staging/fsl-mc/bus/dpbp.c
> index d99ab6d..0004e65 100644
> --- a/drivers/staging/fsl-mc/bus/dpbp.c
> +++ b/drivers/staging/fsl-mc/bus/dpbp.c
> @@ -34,14 +34,19 @@
>  #include "../include/dpbp.h"
>  #include "../include/dpbp-cmd.h"
> 
> -int dpbp_open(struct fsl_mc_io *mc_io, int dpbp_id, uint16_t *token)
> +int dpbp_open(struct fsl_mc_io *mc_io,
> +	      uint32_t cmd_flags,
> +	      int dpbp_id,
> +	      uint16_t *token)
>  {
>  	struct mc_command cmd = { 0 };
>  	int err;
> 
>  	/* prepare command */
>  	cmd.header = mc_encode_cmd_header(DPBP_CMDID_OPEN,
> -					  MC_CMD_PRI_LOW, 0);
> +					  cmd_flags,
> +					  0);

Why are you reformatting all of these calls when you don't have to
create a new line?  Seems wasteful to me, as is:

> +

That empty line, why?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/