linux-kernel - Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Sep 2015 12:16:00 +0800
From:	Yang Yingliang <yangyingliang@...wei.com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Marc Zyngier <marc.zyngier@....com>,
	Mark Rutland <mark.rutland@....com>,
	Will Deacon <will.deacon@....com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Hanjun Guo <hanjun.guo@...aro.org>
Subject: Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for
 cpu hotplug



On 2015/9/23 2:54, Thomas Gleixner wrote:
> On Sat, 19 Sep 2015, Yang Yingliang wrote:
>
>> Add irq_migrate_all_off_this_cpu() into kernel/irq/migration.c.
>
> This doesn't make any sense at all.
>
> You just reuse the existing file to stick your new code into it
> without reusing a single bit in that file. Aside of that it's
> unconditionally compiled, which means all existing users of
> CONFIG_GENERIC_PENDING_IRQ are burdened with pointless code.
>
> The right thing to do is:
>
> Add that code to a new file: kernel/irq/cpuhotplug.c and make that
> depend on CONFIG_GENERIC_IRQ_MIGRATION.

How about add #ifdef CONFIG_CPU_HOTPLUG around new code
in kernel/irq/migration.c ?

Thanks,
Yang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/