linux-kernel - [PATCH 1/2] mm: change free_cma and free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Sep 2015 21:04:16 +0000
From:	Alexandru Moise <00moses.alexander00@...il.com>
To:	akpm@...ux-foundation.org
Cc:	mgorman@...e.de, vbabka@...e.cz, mhocko@...e.com,
	rientjes@...gle.com, js1304@...il.com, hannes@...xchg.org,
	alexander.h.duyck@...hat.com, sasha.levin@...cle.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/2] mm: change free_cma and free_pages declarations to
 unsigned

Their stored values come from zone_page_state() which returns
an unsigned long. To improve code correctness we should avoid
mixing signed and unsigned integers.

Signed-off-by: Alexandru Moise <00moses.alexander00@...il.com>
---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 48aaf7b..f55e3a2 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2242,7 +2242,7 @@ static bool __zone_watermark_ok(struct zone *z, unsigned int order,
 	/* free_pages may go negative - that's OK */
 	long min = mark;
 	int o;
-	long free_cma = 0;
+	unsigned long free_cma = 0;
 
 	free_pages -= (1 << order) - 1;
 	if (alloc_flags & ALLOC_HIGH)
@@ -2280,7 +2280,7 @@ bool zone_watermark_ok(struct zone *z, unsigned int order, unsigned long mark,
 bool zone_watermark_ok_safe(struct zone *z, unsigned int order,
 			unsigned long mark, int classzone_idx, int alloc_flags)
 {
-	long free_pages = zone_page_state(z, NR_FREE_PAGES);
+	unsigned long free_pages = zone_page_state(z, NR_FREE_PAGES);
 
 	if (z->percpu_drift_mark && free_pages < z->percpu_drift_mark)
 		free_pages = zone_page_state_snapshot(z, NR_FREE_PAGES);
-- 
2.5.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/