linux-kernel - Re: [PATCH v2 4/4] perf tools: Enable event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 27 Sep 2015 22:41:54 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	He Kuang <hekuang@...wei.com>
Cc:	a.p.zijlstra@...llo.nl, mingo@...hat.com, acme@...nel.org,
	jolsa@...nel.org, kan.liang@...el.com, adrian.hunter@...el.com,
	wangnan0@...wei.com, pi3orama@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] perf tools: Enable event_config terms to
 tracepoint events

On Fri, Sep 25, 2015 at 11:11:51AM +0000, He Kuang wrote:

SNIP

>  
> +static int config_term_tracepoint(struct perf_event_attr *attr,
> +				  struct parse_events_term *term,
> +				  struct parse_events_error *err)
> +{
> +	switch (term->type_term) {
> +	case PARSE_EVENTS__TERM_TYPE_CALLGRAPH:
> +	case PARSE_EVENTS__TERM_TYPE_STACKSIZE:
> +		return config_term_common(attr, term, err);
> +	default:
> +		if (err) {
> +			err->idx = term->err_term;
> +			err->str = strdup("unknown term");
> +			err->help = strdup(
> +				"valid terms: call-graph,stack-size\n");

please keep that on one line, we dont follow 80 chars rule strictly
if it results in ugly formatting like above

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/