linux-kernel - Re: [PATCH 3/8] mfd: pcf50633: Remove unneded ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Oct 2015 08:18:46 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 3/8] mfd: pcf50633: Remove unneded ret variable

On Tue, 29 Sep 2015, Javier Martinez Canillas wrote:

> The ret variable is not needed since is not used in the
> function. Remove the variable and just return 0 instead.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> ---
> 
>  drivers/mfd/pcf50633-irq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/pcf50633-irq.c b/drivers/mfd/pcf50633-irq.c
> index 498286cbb530..71d43edf110c 100644
> --- a/drivers/mfd/pcf50633-irq.c
> +++ b/drivers/mfd/pcf50633-irq.c
> @@ -55,7 +55,7 @@ EXPORT_SYMBOL_GPL(pcf50633_free_irq);
>  static int __pcf50633_irq_mask_set(struct pcf50633 *pcf, int irq, u8 mask)
>  {
>  	u8 reg, bit;
> -	int ret = 0, idx;
> +	int idx;
>  
>  	idx = irq >> 3;
>  	reg = PCF50633_REG_INT1M + idx;
> @@ -72,7 +72,7 @@ static int __pcf50633_irq_mask_set(struct pcf50633 *pcf, int irq, u8 mask)
>  
>  	mutex_unlock(&pcf->lock);
>  
> -	return ret;
> +	return 0;
>  }
>  
>  int pcf50633_irq_mask(struct pcf50633 *pcf, int irq)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/