linux-kernel - Re: [PATCH 08/16] clk: at91: only enable available IRQs

Open Source and information security mailing list archives

Date:	Thu, 1 Oct 2015 10:24:38 +0200
From:	Ludovic Desroches <ludovic.desroches@...el.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	<linux-kernel@...r.kernel.org>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-clk@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 08/16] clk: at91: only enable available IRQs

On Wed, Sep 30, 2015 at 06:11:01PM +0200, Alexandre Belloni wrote:
> From: Boris Brezillon <boris.brezillon@...e-electrons.com>
> 
> Only enable available IRQs in case writing to a reserved bit has an armful
> effect.

You probably mean disable instead of enable and s/armful/harmful.

> 
> Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
>  drivers/clk/at91/pmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c
> index 6c1f08a73373..45dd32bf2531 100644
> --- a/drivers/clk/at91/pmc.c
> +++ b/drivers/clk/at91/pmc.c
> @@ -287,7 +287,7 @@ static int __init atmel_pmc_probe(struct platform_device *pdev)
>  	if (!pmc->irqdomain)
>  		return 0;
>  
> -	regmap_write(pmc->regmap, AT91_PMC_IDR, 0xffffffff);
> +	regmap_write(pmc->regmap, AT91_PMC_IDR, pmc->caps->available_irqs);
>  	ret = request_irq(pmc->virq, pmc_irq_handler,
>  			  IRQF_SHARED | IRQF_COND_SUSPEND, "pmc", pmc);
>  	if (ret)
> -- 
> 2.1.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives