linux-kernel - Re: [PATCH 3/6 RESEND] mfd: arizona: Downgrade type mismatch messages to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Oct 2015 12:17:13 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, patches@...nsource.wolfsonmicro.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6 RESEND] mfd: arizona: Downgrade type mismatch
 messages to dev_warn

On Mon, 28 Sep 2015, Richard Fitzgerald wrote:

> If the declared codec type doesn't match the detected type
> we issue a log message but carry on registering the device,
> so a dev_warn() is appropriate rather than a dev_err()
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
> ---
>  drivers/mfd/arizona-core.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

For my own reference:
  Acked-by: Lee Jones <lee.jones@...aro.org>

> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index 73d26dd..cb09172 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -1132,8 +1132,8 @@ int arizona_dev_init(struct arizona *arizona)
>  	case 0x5102:
>  		type_name = "WM5102";
>  		if (arizona->type != WM5102) {
> -			dev_err(arizona->dev, "WM5102 registered as %d\n",
> -				arizona->type);
> +			dev_warn(arizona->dev, "WM5102 registered as %d\n",
> +				 arizona->type);
>  			arizona->type = WM5102;
>  		}
>  		apply_patch = wm5102_patch;
> @@ -1151,8 +1151,8 @@ int arizona_dev_init(struct arizona *arizona)
>  			break;
>  		default:
>  			type_name = "WM5110";
> -			dev_err(arizona->dev, "WM5110 registered as %d\n",
> -				arizona->type);
> +			dev_warn(arizona->dev, "WM5110 registered as %d\n",
> +				 arizona->type);
>  			arizona->type = WM5110;
>  			break;
>  		}
> @@ -1163,8 +1163,8 @@ int arizona_dev_init(struct arizona *arizona)
>  	case 0x8997:
>  		type_name = "WM8997";
>  		if (arizona->type != WM8997) {
> -			dev_err(arizona->dev, "WM8997 registered as %d\n",
> -				arizona->type);
> +			dev_warn(arizona->dev, "WM8997 registered as %d\n",
> +				 arizona->type);
>  			arizona->type = WM8997;
>  		}
>  		apply_patch = wm8997_patch;
> @@ -1183,8 +1183,8 @@ int arizona_dev_init(struct arizona *arizona)
>  
>  		default:
>  			type_name = "WM8998";
> -			dev_err(arizona->dev, "WM8998 registered as %d\n",
> -				arizona->type);
> +			dev_warn(arizona->dev, "WM8998 registered as %d\n",
> +				 arizona->type);
>  			arizona->type = WM8998;
>  		}
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/