linux-kernel - Re: [PATCH] ceph: fix message length computation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 1 Oct 2015 21:40:10 +0800
From:	"Yan, Zheng" <ukernel@...il.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	ceph-devel <ceph-devel@...r.kernel.org>, y2038@...ts.linaro.org,
	Ilya Dryomov <idryomov@...il.com>,
	"Yan, Zheng" <zyan@...hat.com>, Sage Weil <sage@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ceph: fix message length computation

On Wed, Sep 30, 2015 at 9:04 PM, Arnd Bergmann <arnd@...db.de> wrote:
> create_request_message() computes the maximum length of a message,
> but uses the wrong type for the time stamp: sizeof(struct timespec)
> may be 8 or 16 depending on the architecture, while sizeof(struct
> ceph_timespec) is always 8, and that is what gets put into the
> message.
>
> Found while auditing the uses of timespec for y2038 problems.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: b8e69066d8af ("ceph: include time stamp in every MDS request")
> ---
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 51cb02da75d9..fe2c982764e7 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -1935,7 +1935,7 @@ static struct ceph_msg *create_request_message(struct ceph_mds_client *mdsc,
>
>         len = sizeof(*head) +
>                 pathlen1 + pathlen2 + 2*(1 + sizeof(u32) + sizeof(u64)) +
> -               sizeof(struct timespec);
> +               sizeof(struct ceph_timespec);
>
>         /* calculate (max) length for cap releases */
>         len += sizeof(struct ceph_mds_request_release) *
>

Applied. thanks

Yan, Zheng

> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/