linux-kernel - Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Oct 2015 11:12:12 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
Subject: Re: linux-next: Tree for Oct 1 (arch/x86/ras/mce_amd_inj.c)

On 10/01/15 10:49, Borislav Petkov wrote:
> On Thu, Oct 01, 2015 at 10:39:32AM -0700, Randy Dunlap wrote:
>> On 09/30/15 23:50, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20150930:
>>>
>>
>>
>> on x86_64:
>>
>> ../arch/x86/ras/mce_amd_inj.c: In function 'toggle_nb_mca_mst_cpu':
>> ../arch/x86/ras/mce_amd_inj.c:214:42: warning: dereferencing 'void *' pointer [enabled by default]
>>   struct pci_dev *F3 = node_to_amd_nb(nid)->misc;
>>                                           ^
>> ../arch/x86/ras/mce_amd_inj.c:214:42: error: request for member 'misc' in something not a structure or union
> 
> Thanks Randy,
> 
> this is most likely due to us using node_to_amd_nb() - an AMD_NB
> facility - but we're not depending on it. Does that help?

Yes, thanks.

Acked-by: Randy Dunlap <rdunlap@...radead.org>


> ---
> diff --git a/arch/x86/ras/Kconfig b/arch/x86/ras/Kconfig
> index 10fea5fc821e..98b3ef750984 100644
> --- a/arch/x86/ras/Kconfig
> +++ b/arch/x86/ras/Kconfig
> @@ -1,6 +1,6 @@
>  config AMD_MCE_INJ
>  	tristate "Simple MCE injection interface for AMD processors"
> -	depends on RAS && EDAC_DECODE_MCE && DEBUG_FS
> +	depends on RAS && EDAC_DECODE_MCE && DEBUG_FS && AMD_NB
>  	default n
>  	help
>  	  This is a simple debugfs interface to inject MCEs and test different
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/