linux-kernel - Re: [PATCH 1/2] iio: fix drivers that use 0 as a valid IRQ in client->irq (part 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 3 Oct 2015 11:07:46 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Octavian Purdila <octavian.purdila@...el.com>, knaack.h@....de,
	lars@...afoo.de, pmeerw@...erw.net
Cc:	srinivas.pandruvada@...ux.intel.com, hadess@...ess.net,
	daniel.baluta@...el.com, irina.tirdea@...el.com, ao2@....it,
	u.kleine-koenig@...gutronix.de, vlad.dogaru@...el.com,
	linus.walleij@...aro.org, tiberiu.a.breana@...el.com,
	javier@....samsung.com, dan.carpenter@...cle.com,
	geert@...ux-m68k.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: fix drivers that use 0 as a valid IRQ in
 client->irq (part 2)

On 23/09/15 10:02, Octavian Purdila wrote:
> Since commit dab472eb931bc291 ("i2c / ACPI: Use 0 to indicate that
> device does not have interrupt assigned") 0 is not a valid i2c
> client irq anymore, so change all driver's checks accordingly.
> 
> The same issue occurs when the device is instantiated via device tree
> with no IRQ, or from the i2c sysfs interface, even before the patch
> above.
> 
> Signed-off-by: Octavian Purdila <octavian.purdila@...el.com>
Applied to the togreg branch of iio.git. Initially pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/accel/stk8312.c  | 2 +-
>  drivers/iio/accel/stk8ba50.c | 2 +-
>  drivers/iio/light/stk3310.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
> index c764af2..a578694 100644
> --- a/drivers/iio/accel/stk8312.c
> +++ b/drivers/iio/accel/stk8312.c
> @@ -572,7 +572,7 @@ static int stk8312_probe(struct i2c_client *client,
>  	if (client->irq < 0)
>  		client->irq = stk8312_gpio_probe(client);
>  
> -	if (client->irq >= 0) {
> +	if (client->irq > 0) {
>  		ret = devm_request_threaded_irq(&client->dev, client->irq,
>  						stk8312_data_rdy_trig_poll,
>  						NULL,
> diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c
> index 80f77d8..a59f5d8 100644
> --- a/drivers/iio/accel/stk8ba50.c
> +++ b/drivers/iio/accel/stk8ba50.c
> @@ -468,7 +468,7 @@ static int stk8ba50_probe(struct i2c_client *client,
>  	if (client->irq < 0)
>  		client->irq = stk8ba50_gpio_probe(client);
>  
> -	if (client->irq >= 0) {
> +	if (client->irq > 0) {
>  		ret = devm_request_threaded_irq(&client->dev, client->irq,
>  						stk8ba50_data_rdy_trig_poll,
>  						NULL,
> diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
> index 25c6a71..4e56c90 100644
> --- a/drivers/iio/light/stk3310.c
> +++ b/drivers/iio/light/stk3310.c
> @@ -636,7 +636,7 @@ static int stk3310_probe(struct i2c_client *client,
>  		}
>  	}
>  
> -	if (client->irq >= 0) {
> +	if (client->irq > 0) {
>  		ret = devm_request_threaded_irq(&client->dev, client->irq,
>  						stk3310_irq_handler,
>  						stk3310_irq_event_handler,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/