linux-kernel - Re: [PATCH 1/3] signal: turn dequeue_signal_lock() into kernel_dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 4 Oct 2015 12:38:36 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Felipe Balbi <balbi@...com>,
	Markus Pargmann <mpa@...gutronix.de>,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 1/3] signal: turn dequeue_signal_lock() into
 kernel_dequeue_signal()

On Sat, Oct 03, 2015 at 08:13:36PM +0200, Oleg Nesterov wrote:
> 1. Rename dequeue_signal_lock() to kernel_dequeue_signal(). This
>    matches another "for kthreads only" kernel_sigaction() helper.
> 
> 2. Remove the "tsk" and "mask" arguments, they are always current
>    and current->blocked. And it is simply wrong if tsk != current.
> 
> 3. We could also remove the 3rd "siginfo_t *info" arg but it looks
>    potentially useful. However we can simplify the callers if we
>    change kernel_dequeue_signal() to accept info => NULL.
> 
> 4. Remove _irqsave, it is never called from atomic context.
> 
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

FWIW, looks good to me.

Reviewed-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/