linux-kernel - Re: [PATCH v6 3/6] power: Add support for DA9150 Fuel-Gauge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 Oct 2015 13:10:12 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Adam Thomson <Adam.Thomson.Opensource@...semi.com>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Sebastian Reichel <sre@...nel.org>,
	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH v6 3/6] power: Add support for DA9150 Fuel-Gauge

On Mon, Oct 5, 2015 at 1:03 PM, Adam Thomson
<Adam.Thomson.Opensource@...semi.com> wrote:

> +       /* Register IRQ */
> +       irq = platform_get_irq_byname(pdev, "FG");
> +       if (irq < 0) {
> +               dev_err(dev, "Failed to get IRQ FG: %d\n", irq);

You need to do "ret = irq" here. Otherwise you will return success in irq_fail.

> +               goto irq_fail;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/