linux-kernel - Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Oct 2015 08:56:36 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Joe Perches <joe@...ches.com>
Cc:	Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
	davem@...emloft.net, Jiri Pirko <jiri@...lanox.com>,
	Ido Schimmel <idosch@...lanox.com>,
	linux-kernel@...r.kernel.org, Elad Raz <eladr@...lanox.com>,
	Scott Feldman <sfeldma@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

Wed, Oct 07, 2015 at 08:53:02AM CEST, joe@...ches.com wrote:
>On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote:
>> The recently added mlxsw driver produces warnings in ARM
>> allmodconfig:
>> 
>> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
>> drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow]
>> linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32'
>> drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be'
>> 
>> This changes the type of the local variable to u64, which gets rid of the
>> warning and seems nicer than adding #ifdefs.
>
>Using upper_32_bits instead of the shift might be
>nicer than changing the type.

Wasn't aware of this macro. Indeed this looks more appropriate. Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/