linux-kernel - Re: [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures

Open Source and information security mailing list archives

Date:	Mon, 12 Oct 2015 10:51:51 +1000
From:	Ben Skeggs <skeggsb@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>,
	David Airlie <airlied@...ux.ie>
Cc:	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 10/11/2015 10:18 PM, Julia Lawall wrote:
> These nvkm_object_func structures are never modified.  All other 
> nvkm_object_func structures are declared as const.
> 
> Done with the help of Coccinelle.
I've picked up the patch, thanks!

Ben.

> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> --- drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c |    2 +- 
> drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c       |    2 +- 2
> files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c index
> 62d3fb6..2be8463 100644 ---
> a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c +++
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c @@ -109,7
> +109,7 @@ nv04_disp_mthd(struct nvkm_object *object, u32 mthd, void
> *data, u32 size) return -EINVAL; }
> 
> -static struct nvkm_object_func +static const struct
> nvkm_object_func nv04_disp_root = { .mthd = nv04_disp_mthd, .ntfy =
> nvkm_disp_ntfy, diff --git
> a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c index
> 0db9be2..2721592 100644 ---
> a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c +++
> b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c @@ -633,7 +633,7 @@
> nvkm_perfmon_dtor(struct nvkm_object *object) return perfmon; }
> 
> -static struct nvkm_object_func +static const struct
> nvkm_object_func nvkm_perfmon = { .dtor = nvkm_perfmon_dtor, .mthd
> = nvkm_perfmon_mthd,
> 
> _______________________________________________ dri-devel mailing
> list dri-devel@...ts.freedesktop.org 
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWGwQdAAoJEHYLnGJQkpH74lsQAMlUrNJ9gRc1d6P6fKcTwVGa
YwBG8R2pg+nQ4UY9GoFvTJO1CSanG+4bLM88ccTDeuF7nIhV9g7Z8vPg8Jy1B2ZX
V7mVvNdO+sagYT6PcitXzDDirM6yoNZLf+7y0I+8HPNwg9TBCXUFZCF0w3DY0Txu
S6HZmCO/rlhQJFGuOsOrfKAtrEwIaw1JiAWMS8VUNbjdzHgozetJQgq7xAoe49A2
GGtQ6b1JtI8bmzYDVhJmhSqzTwBmZO5RLL6Wo3DFta/E6bR6SQgpeU2im9lkwgKH
WOBkotpg/EJJ4ltSMpjOkJlTu5xWEUr12RA5SYlcyWEX7XwnLX7S4TXa8Dh6jIFE
Jv4tnWsKVFrzLKQ/Q75uaFgbhJiWt8VNpfGaLmnnI3qYjujAoXBgiapp7Xi/fd25
vUx1j/OWmKQy3dDdjAQKXDp2MK+DrJig7lfQahwGQRztLwvMv65hq7fXLlt0LbjH
DzU9Q2VzSbEfW02zDcgCem7gIUf+X3cKkMx2c9Bok56cGOybUPm33OFFZ5IE0KJ4
3yRHE5aq2kzeWsN99N/IvyE6WhtK+kCNmEfkddYOvPQ3XioAk1zjNAdkQudM0Ii0
JWjFFVt0fixVOl8zmGIDNFNBnzYKu5SwvA31Usr1Vsltx+c4LXAmIGG6/vey5Uiv
WmpIfcA3EmL2jRoaS/DG
=00y+
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives